Follow-up from "Gui bug fixes"
The following discussion from !85 (merged) should be addressed:
I appreciate extracting this method from
processNewTransaction, I think it was definitely a right thing to do. However, having said that, this function contains several responsibilities, which usually belong not just to different functions or classes, but to different architectural layers:
- Showing dialogs / formatting strings - UI layer
- Manipulating configs - Infrastructure layer
- Manipulating objects from domain layer, setting port numbers - Application layer
We should consider refactoring this function towards better separation of concerns.
(layers are given as described, for example, here: http://wiki.c2.com/?FourLayerArchitecture)