PoS testing: mnbudget prepare charges fee but doesn't actually prepare proposal, gives no warning (#281) · Issues · Crown / crown-core

PoS testing: mnbudget prepare charges fee but doesn't actually prepare proposal, gives no warning

Summary

Tried to prepare a proposal. Received a txid output but debug.log shows txn was rejected, and the proposal was not created.

Steps to reproduce

Attempt to prepare a proposal, eg:

crown-cli mnbudget prepare "walk02" "walkjivefly.com" 10 15250 tCRWPFou6bJ3ya1zjrDhdCrGXVhN5oaGVa5XN 20

Expected behavior

If not too close to the next superblock the proposal is prepared.

Problematic behavior

Was charged 25tCRW and txid was displayed (fe5cb1b6d3470c7a0b31299086cd2badb517e061fcc2ff984388b326596470b6) but the proposal was not prepared.

Crown-core environment info

MX 17.1 linux

Crown-core application info

Crown version v0.12.7.1-2029222a pipeline 873 build 5011

Relevant logs, dumps and/or screenshots

2019-01-16 08:36:06 CommitTransaction:
CTransaction(hash=fe5cb1b6d3, ver=1, vin.size=6, vout.size=2, nLockTime=0)
    CTxIn(COutPoint(55e39498294920719cfe200b9c0b217870748ab60975836fcfe81b83cdfb670d, 0), scriptSig=30440220450da379f3e24348)
    CTxIn(COutPoint(7185da6a8efd8c6fdea2810542fbb0fef5c017fc63fc25ed0d21a6914c525638, 0), scriptSig=3044022010b0eb7fd2880bab)
    CTxIn(COutPoint(7e35a7990da355de094f211686660ce8194ca42463b0ca616b03d64829033337, 1), scriptSig=3045022100ab67969d7fdee7)
    CTxIn(COutPoint(6d1a3d43ce1888172b5df30e37a19a00604c00ea290a426589dc83689b9c2245, 1), scriptSig=304402207a7dc1317825d5c2)
    CTxIn(COutPoint(63c7c8a329c19bc8f5ab29813e1938f9619e2343283d5037a95cdab89fc64074, 1), scriptSig=3045022100c33f40b6fbc5cf)
    CTxIn(COutPoint(6525ebd62b835df8ae83cdb2cbc011032fc9d76fc5b1df2161522f81794280f5, 0), scriptSig=30440220633961d1d8697793)
    CTxOut(nValue=0.79008711, scriptPubKey=OP_DUP OP_HASH160 41ae02d9036b)
    CTxOut(nValue=25.00000000, scriptPubKey=OP_RETURN db133be898a0ff3df1ae)
2019-01-16 08:36:06 AddToWallet fe5cb1b6d3470c7a0b31299086cd2badb517e061fcc2ff984388b326596470b6  new
2019-01-16 08:36:06 ERROR: CheckInputs() : tried to spend coinbase at depth 11
2019-01-16 08:36:06 ERROR: AcceptToMemoryPool: : ConnectInputs failed fe5cb1b6d3470c7a0b31299086cd2badb517e061fcc2ff984388b326596470b6
2019-01-16 08:36:06 CommitTransaction() : Error: Transaction not valid

Drop full logs & dumps here: https://nextcloud.crown.tech/nextcloud/s/znd8HiiAsRX3C6B 20190116_walkjivefly_wallet.log uploaded to nextcloud

Possible fixes

The problem is shown 3 times in the above debug.log. Every time one of the inputs is the change output from txn 55e39498294920719cfe200b9c0b217870748ab60975836fcfe81b83cdfb670d which is the fee hash of the walk01 proposal from issue #280 (closed)

/cc @artem

### Summary
Tried to prepare a proposal. Received a txid output but debug.log shows txn was rejected, and the proposal was not created.

### Steps to reproduce
Attempt to prepare a proposal, eg:
```
crown-cli mnbudget prepare "walk02" "walkjivefly.com" 10 15250 tCRWPFou6bJ3ya1zjrDhdCrGXVhN5oaGVa5XN 20
```

### Expected behavior
If not too close to the next superblock the proposal is prepared.

### Problematic behavior
Was charged 25tCRW and txid was displayed (fe5cb1b6d3470c7a0b31299086cd2badb517e061fcc2ff984388b326596470b6) but the proposal was not prepared.

### Crown-core environment info
MX 17.1 linux

### Crown-core application info
Crown version v0.12.7.1-2029222ac pipeline 873 build 5011

### Relevant logs, dumps and/or screenshots
```
2019-01-16 08:36:06 CommitTransaction:
CTransaction(hash=fe5cb1b6d3, ver=1, vin.size=6, vout.size=2, nLockTime=0)
    CTxIn(COutPoint(55e39498294920719cfe200b9c0b217870748ab60975836fcfe81b83cdfb670d, 0), scriptSig=30440220450da379f3e24348)
    CTxIn(COutPoint(7185da6a8efd8c6fdea2810542fbb0fef5c017fc63fc25ed0d21a6914c525638, 0), scriptSig=3044022010b0eb7fd2880bab)
    CTxIn(COutPoint(7e35a7990da355de094f211686660ce8194ca42463b0ca616b03d64829033337, 1), scriptSig=3045022100ab67969d7fdee7)
    CTxIn(COutPoint(6d1a3d43ce1888172b5df30e37a19a00604c00ea290a426589dc83689b9c2245, 1), scriptSig=304402207a7dc1317825d5c2)
    CTxIn(COutPoint(63c7c8a329c19bc8f5ab29813e1938f9619e2343283d5037a95cdab89fc64074, 1), scriptSig=3045022100c33f40b6fbc5cf)
    CTxIn(COutPoint(6525ebd62b835df8ae83cdb2cbc011032fc9d76fc5b1df2161522f81794280f5, 0), scriptSig=30440220633961d1d8697793)
    CTxOut(nValue=0.79008711, scriptPubKey=OP_DUP OP_HASH160 41ae02d9036b)
    CTxOut(nValue=25.00000000, scriptPubKey=OP_RETURN db133be898a0ff3df1ae)
2019-01-16 08:36:06 AddToWallet fe5cb1b6d3470c7a0b31299086cd2badb517e061fcc2ff984388b326596470b6  new
2019-01-16 08:36:06 ERROR: CheckInputs() : tried to spend coinbase at depth 11
2019-01-16 08:36:06 ERROR: AcceptToMemoryPool: : ConnectInputs failed fe5cb1b6d3470c7a0b31299086cd2badb517e061fcc2ff984388b326596470b6
2019-01-16 08:36:06 CommitTransaction() : Error: Transaction not valid
```

Drop full logs & dumps here: https://nextcloud.crown.tech/nextcloud/s/znd8HiiAsRX3C6B
20190116_walkjivefly_wallet.log uploaded to nextcloud

### Possible fixes
The problem is shown 3 times in the above debug.log. Every time one of the inputs is the change output from txn 55e39498294920719cfe200b9c0b217870748ab60975836fcfe81b83cdfb670d which is the fee hash of the walk01 proposal from issue #280